netdev - Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMgb0MnO8O2_0cQQkjmwe2PcjXb5PeOexRPfejpsyX98zg@mail.gmail.com>
Date:   Tue, 5 Feb 2019 11:03:01 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
Cc:     "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Hadar Hen Zion <hadarh@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source
 mac changed

On Wed, Jan 30, 2019 at 12:20 AM Saeed Mahameed <saeedm@...lanox.com> wrote:
>
> On Mon, 2019-01-28 at 15:28 -0800, xiangxia.m.yue@...il.com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> >
> > When we offload tc filters to hardware, hardware flows can
> > be updated when mac of encap destination ip is changed.
> > But we ignore one case, that the mac of local encap ip can
> > be changed too, so we should also update them.
> >
> > To fix it, add route_dev in mlx5e_encap_entry struct to save
> > the local encap netdevice, and when mac changed, kernel will
> > flush all the neighbour on the netdevice and send
> > NETEVENT_NEIGH_UPDATE
> > event. The mlx5 driver will delete the flows and add them when
> > neighbour
> > available again.
> >
> > Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update
> > flow")
> > Cc: Hadar Hen Zion <hadarh@...lanox.com>
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> > Reviewed-by: Or Gerlitz <ogerlitz@...lanox.com>
> >
> >
>
> Thank you Tonghao and Or.
>
> Acked-by: Saeed Mahameed <saeedm@...lanox.com>

Dave, I see a copy of the patch on patchworks [1] with status being
not applicable, what is missing here? the patch should apply AFAIK.
There was also another patch reviewed here by me and Saeed [2], not
sure where it stands from your side.

[1] https://patchwork.ozlabs.org/patch/1023844/
[2] https://marc.info/?l=linux-netdev&m=154878514916414&w=2