lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e0d0f0b8-9f26-8e82-d5a1-0fb3ab03b318@huawei.com> Date: Fri, 1 Feb 2019 11:15:08 +0800 From: YueHaibing <yuehaibing@...wei.com> To: <davem@...emloft.net>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <lipeng321@...wei.com> CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] net: hns3: Fix potential NULL dereference on allocation error ping ... On 2019/1/25 11:13, YueHaibing wrote: > hclge_mac_update_stats_complete doesn't check for NULL > returns of kcalloc, it may result in an Oops. > > Fixes: d174ea75c96a ("net: hns3: add statistics for PFC frames and MAC control frames") > Signed-off-by: YueHaibing <yuehaibing@...wei.com> > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > index 64b1589..7971606 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > @@ -343,6 +343,9 @@ static int hclge_mac_update_stats_complete(struct hclge_dev *hdev, u32 desc_num) > int ret; > > desc = kcalloc(desc_num, sizeof(struct hclge_desc), GFP_KERNEL); > + if (!desc) > + return -ENOMEM; > + > hclge_cmd_setup_basic_desc(&desc[0], HCLGE_OPC_STATS_MAC_ALL, true); > ret = hclge_cmd_send(&hdev->hw, desc, desc_num); > if (ret) { >
Powered by blists - more mailing lists