netdev - Re: [PATCH bpf-next v5 5/8] xdp: Provide extack messages when prog attachment failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190131191101.2e9dc9f6@cakuba.hsd1.ca.comcast.net>
Date:   Thu, 31 Jan 2019 19:11:01 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     daniel@...earbox.net, ast@...nel.org,
        David Miller <davem@...emloft.net>
Cc:     Maciej Fijalkowski <maciejromanfijalkowski@...il.com>,
        netdev@...r.kernel.org, brouer@...hat.com,
        john.fastabend@...il.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH bpf-next v5 5/8] xdp: Provide extack messages when prog
 attachment failed

On Fri,  1 Feb 2019 01:19:51 +0100, Maciej Fijalkowski wrote:
>  		if (__dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG) ||
> -		    __dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG_HW))
> +		    __dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG_HW)) {
> +			NL_SET_ERR_MSG(extack, "native and generic XDP can't be active at the same time");
>  			return -EEXIST;
> +		}

This reminds me, since we allowed native/driver and offloaded XDP
programs to coexist in a25717d2b604 ("xdp: support simultaneous 
driver and hw XDP attachment") I got an internal feature request 
to also allow generic and native mode.  Would anyone object to that?

Apart from a touch up to test_offload.py I don't think anything 
would care.  netlink can already carry multiple IDs, iproute2
understands it, too..

(Obviously as a follow up after this set gets merged.)