netdev - Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOrHB_B9+3BdVXQRSx31YhmObp4XUQfnm+dedL5qLqMJMR6B6w@mail.gmail.com>
Date:   Thu, 31 Jan 2019 18:39:22 -0800
From:   Pravin Shelar <pshelar@....org>
To:     Eli Britstein <elibr@...lanox.com>
Cc:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "blp@....org" <blp@....org>,
        "dev@...nvswitch.org" <dev@...nvswitch.org>,
        Roi Dayan <roid@...lanox.com>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>
Subject: Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures
 using macros

Can you send patch with this information in commit msg?


On Thu, Jan 31, 2019 at 3:32 AM Eli Britstein <elibr@...lanox.com> wrote:
>
> ping
>
> for the using patch, i put below the v1 of it. here is v2:
>
> https://patchwork.ozlabs.org/patch/1023406/
>
>
> On 1/27/2019 8:37 AM, Eli Britstein wrote:
> >
> > On 1/27/2019 1:04 AM, David Miller wrote:
> >> From: Eli Britstein <elibr@...lanox.com>
> >> Date: Thu, 24 Jan 2019 11:46:47 +0200
> >>
> >>> Declare ovs key structures using macros to enable retrieving fields
> >>> information, with no functional change.
> >>>
> >>> Signed-off-by: Eli Britstein <elibr@...lanox.com>
> >>> Reviewed-by: Roi Dayan <roid@...lanox.com>
> >> I agree with Pravin, this need a much better commit message.
> >>
> >> Maybe even better to submit this alongside whatever is supposed
> >> to use these new macros.
> >
> > This patch is equivalent to a work done in the OVS tree.
> >
> > https://patchwork.ozlabs.org/patch/1023405/
> >
> > As a standalone it doesn't serve any purpose (as mentioned - no
> > functional change).
> >
> > It serves as a pre-step towards another patch in the OVS:
> >
> > https://patchwork.ozlabs.org/patch/1022794/
> >
> > So, the purpose of doing it in the kernel is just to keep this H file
> > identical. Once it is approved for the kernel, we will be able to
> > proceed with it in the OVS.
> >