lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e5e29586-d372-0920-9787-fe687e66603b@fb.com> Date: Fri, 1 Feb 2019 23:20:44 +0000 From: Yonghong Song <yhs@...com> To: Arnaldo Carvalho de Melo <acme@...nel.org> CC: Arnaldo Carvalho de Melo <acme@...hat.com>, Magnus Karlsson <magnus.karlsson@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...com>, Daniel Borkmann <daniel@...earbox.net>, Kernel Team <Kernel-team@...com> Subject: Re: [PATCH bpf-next v2 1/3] tools/bpf: move libbpf pr_* debug print functions to headers On 2/1/19 3:10 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 01, 2019 at 09:47:31AM -0800, Yonghong Song escreveu: >> @@ -698,13 +695,13 @@ struct btf_ext *btf_ext__new(__u8 *data, __u32 size, btf_print_fn_t err_log) >> if (!btf_ext) >> return ERR_PTR(-ENOMEM); >> >> - err = btf_ext_copy_func_info(btf_ext, data, size, err_log); >> + err = btf_ext_copy_func_info(btf_ext, data, size); >> if (err) { >> btf_ext__free(btf_ext); > > One thing I noticed whas that the class + __ + method is not being > consistently followed, will this be dealt with in a followup patch, i.e. > to make this consistently use the format used in the > btf_ext__free(btf_ext) case? Currently, the API functions have both +_+ and +__+ method names. The +_+ is for APIs having a close one-to-one mapping to system calls. The +__+ is for APIs a little bit high level. Did you find any particular method whose format is not quite right? > >> return ERR_PTR(err); >> } >> >> - err = btf_ext_copy_line_info(btf_ext, data, size, err_log); >> + err = btf_ext_copy_line_info(btf_ext, data, size); >> if (err) { >> btf_ext__free(btf_ext); >> return ERR_PTR(err); > > - Arnaldo >
Powered by blists - more mailing lists