netdev - Re: [PATCH net-next v4 8/8] ethtool: add compat for devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190201075802.GB2401@nanopsycho>
Date:   Fri, 1 Feb 2019 08:58:02 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, andrew@...n.ch, f.fainelli@...il.com,
        mkubecek@...e.cz, eugenem@...com, jonathan.lemon@...il.com
Subject: Re: [PATCH net-next v4 8/8] ethtool: add compat for devlink info

Thu, Jan 31, 2019 at 07:50:47PM CET, jakub.kicinski@...ronome.com wrote:
>If driver did not fill the fw_version field, try to call into
>the new devlink get_info op and collect the versions that way.
>We assume ethtool was always reporting running versions.
>
>v4:
> - use IS_REACHABLE() to avoid problems with DEVLINK=m (kbuildbot).
>v3 (Jiri):
> - do a dump and then parse it instead of special handling;
> - concatenate all versions (well, all that fit :)).
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>