netdev - Re: [Patch net-next] net_sched: add performance counters for basic filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea0ef016-8d87-f358-0c80-a3d42da7fae4@gmail.com>
Date:   Sun, 3 Feb 2019 10:35:55 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [Patch net-next] net_sched: add performance counters for basic
 filter



On 01/17/2019 05:14 PM, Cong Wang wrote:
> Similar to u32 filter, it is useful to know how many times
> we reach each basic filter and how many times we pass the
> ematch attached to it.
> 
> Sample output:
> 
> filter protocol arp pref 49152 basic chain 0
> filter protocol arp pref 49152 basic chain 0 handle 0x1  (rule hit 3 success 3)
> 	action order 1: gact action pass
> 	 random type none pass val 0
> 	 index 1 ref 1 bind 1 installed 81 sec used 4 sec
> 	Action statistics:
> 	Sent 126 bytes 3 pkt (dropped 0, overlimits 0 requeues 0)
> 	backlog 0b 0p requeues 0

...

> +	for_each_possible_cpu(cpu) {
> +		struct tc_basic_pcnt *pf = per_cpu_ptr(f->pf, cpu);
> +
> +		gpf.rcnt += pf->rcnt;
> +		gpf.rhit += pf->rhit;
> +	}
> 
This looks missing some synchronization of some sort for 32bit kernels ?