netdev - Re: [Patch net-next] net_sched: add performance counters for basic filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpX2zTa0E9sJkhyyq3_1NmdqhPXfk8L=skU6TfKTwvBYhg@mail.gmail.com>
Date:   Sun, 3 Feb 2019 11:35:26 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [Patch net-next] net_sched: add performance counters for basic filter

On Sun, Feb 3, 2019 at 10:35 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
> > +     for_each_possible_cpu(cpu) {
> > +             struct tc_basic_pcnt *pf = per_cpu_ptr(f->pf, cpu);
> > +
> > +             gpf.rcnt += pf->rcnt;
> > +             gpf.rhit += pf->rhit;
> > +     }
> >
> This looks missing some synchronization of some sort for 32bit kernels ?

I don't know, u32 filter has literally same code:

                for_each_possible_cpu(cpu) {
                        int i;
                        struct tc_u32_pcnt *pf = per_cpu_ptr(n->pf, cpu);

                        gpf->rcnt += pf->rcnt;
                        gpf->rhit += pf->rhit;
                        for (i = 0; i < n->sel.nkeys; i++)
                                gpf->kcnts[i] += pf->kcnts[i];
                }

which has been there for years...