netdev - Re: [PATCH iproute2-next v5] devlink: add info subcommand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190204161602.GA11362@nanopsycho>
Date:   Mon, 4 Feb 2019 17:16:02 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     dsahern@...il.com, stephen@...workplumber.org,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2-next v5] devlink: add info subcommand

Mon, Feb 04, 2019 at 05:10:11PM CET, jakub.kicinski@...ronome.com wrote:
>Add support for reading the device serial number, driver name
>and various versions.  Example:
>
>$ devlink dev info pci/0000:82:00.0
>pci/0000:82:00.0:
>  driver nfp
>  serial_number 16240145
>  versions:
>      fixed:
>        board.id AMDA0081-0001
>        board.rev 15
>        board.vendor SMA
>        board.model hydrogen
>      running:
>        fw.mgmt 010181.010181.0101d4
>        fw.cpld 0x1030000
>        fw.app abm-d372b6
>        fw.undi 0.0.2
>        chip.init AMDA-0081-0001  20160318164536
>      stored:
>        fw.mgmt 010181.010181.0101d4
>        fw.app abm-d372b6
>        fw.undi 0.0.2
>        chip.init AMDA-0081-0001  20160318164536
>
>$ devlink -jp dev info pci/0000:82:00.0
>{
>    "info": {
>        "pci/0000:82:00.0": {
>            "driver": "nfp",
>            "serial_number": "16240145",
>            "versions": {
>                "fixed": {
>                    "board.id": "AMDA0081-0001",
>                    "board.rev": "15",
>                    "board.vendor": "SMA",
>                    "board.model": "hydrogen"
>                },
>                "running": {
>                    "fw.mgmt": "010181.010181.0101d4",
>                    "fw.cpld": "0x1030000",
>                    "fw.app": "abm-d372b6",
>                    "fw.undi": "0.0.2",
>                    "chip.init": "AMDA-0081-0001  20160318164536"
>                },
>                "stored": {
>                    "fw.mgmt": "010181.010181.0101d4",
>                    "fw.app": "abm-d372b6",
>                    "fw.undi": "0.0.2",
>                    "chip.init": "AMDA-0081-0001  20160318164536"
>                }
>            }
>        }
>    }
>}
>
>v5:
> - remove spurious new line.
>v4:
> - more commit message improvements.
>v3:
> - show up-to-date output in the commit message.
>v2 (Jiri):
> - remove filtering;
> - add example in the commit message.
>RFCv2:
> - make info subcommand of dev.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks!