netdev - Re: [PATCH v2] net: emac: remove IBM_EMAC_RX_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Feb 2019 10:36:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     chunkeey@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: emac: remove IBM_EMAC_RX_SKB_HEADROOM

From: Christian Lamparter <chunkeey@...il.com>
Date: Mon,  4 Feb 2019 22:58:29 +0100

> @@ -1195,6 +1195,27 @@ static inline int emac_alloc_rx_skb(struct emac_instance *dev, int slot,
>  	return 0;
>  }
>  
> +static inline int
> +emac_alloc_rx_skb(struct emac_instance *dev, int slot)
> +{
> +	struct sk_buff *skb;
> +
> +	skb = __netdev_alloc_skb_ip_align(dev->ndev, dev->rx_skb_size,
> +					  GFP_KERNEL);
> +
> +	return __emac_prepare_rx_skb(skb, dev, slot);
> +}
> +
> +static inline int
> +emac_alloc_rx_skb_napi(struct emac_instance *dev, int slot)
> +{
> +	struct sk_buff *skb;
> +
> +	skb = napi_alloc_skb(&dev->mal->napi, dev->rx_skb_size);
> +
> +	return __emac_prepare_rx_skb(skb, dev, slot);
> +}
> +

Do not use the inline keyword in foo.c files, let the compiler decide.

Thank you.