netdev - Re: [PATCH net-next v3 15/16] net: sched: refactor tcf_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205133023.GM2133@nanopsycho>
Date:   Tue, 5 Feb 2019 14:30:23 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next v3 15/16] net: sched: refactor tcf_block_find()
 into standalone functions

Mon, Feb 04, 2019 at 01:33:00PM CET, vladbu@...lanox.com wrote:
>Refactor tcf_block_find() code into three standalone functions:
>- __tcf_qdisc_find() to lookup Qdisc and increment its reference counter.
>- __tcf_qdisc_cl_find() to lookup class.
>- __tcf_block_find() to lookup block and increment its reference counter.
>
>This change is necessary to allow netlink tc rule update handlers to call
>these functions directly in order to conditionally take rtnl lock
>according to Qdisc class ops flags before calling any of class ops
>functions.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>