netdev - Re: [PATCH net-next v3 16/16] net: sched: unlock rules update API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190205133119.GN2133@nanopsycho>
Date:   Tue, 5 Feb 2019 14:31:19 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next v3 16/16] net: sched: unlock rules update API

Mon, Feb 04, 2019 at 01:33:01PM CET, vladbu@...lanox.com wrote:
>Register netlink protocol handlers for message types RTM_NEWTFILTER,
>RTM_DELTFILTER, RTM_GETTFILTER as unlocked. Set rtnl_held variable that
>tracks rtnl mutex state to be false by default.
>
>Introduce tcf_proto_is_unlocked() helper that is used to check
>tcf_proto_ops->flag to determine if ops can be called without taking rtnl
>lock. Manually lookup Qdisc, class and block in rule update handlers.
>Verify that both Qdisc ops and proto ops are unlocked before using any of
>their callbacks, and obtain rtnl lock otherwise.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>