netdev - Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f153cae-b30f-3e27-488c-9aa8964709f2@st.com>
Date:   Wed, 6 Feb 2019 13:56:27 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Ilias Apalodimas <ilias.apalodimas@...aro.org>
CC:     <peppe.cavallaro@...com>, <davem@...emloft.net>,
        <mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>,
        <joabreu@...opsys.com>
Subject: Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on
 gmac4

Hi Ilias

On 2/5/19 1:15 PM, Ilias Apalodimas wrote:
> The current driver only enables Pdelay_Req and Pdelay_Resp when
> HWTSTAMP_FILTER_PTP_V2_EVENT, HWTSTAMP_FILTER_PTP_V1_L4_EVENT or
> HWTSTAMP_FILTER_PTP_V2_L4_EVENT is requested. This results in ptp sync on
> slave mode to report 'received SYNC without timestamp' when using ptp4l.
> 
> Although the hardware can support Sync, Pdelay_Req and Pdelay_resp by
> setting bit14 annd bits 17/16 to 01 this leaves Delay_Req timestamps out.
> 
> Fix this by enabling all event and general messages timestamps.
> This includes SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req,
> Pdelay_Resp and Pdelay_Resp_Follow_Up messages.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

For GMAC4 part:

Tested-by: Alexandre TORGUE <alexandre.torgue@...com>