netdev - Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190206.172841.19020410876653677.davem@davemloft.net>
Date:   Wed, 06 Feb 2019 17:28:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ilias.apalodimas@...aro.org
Cc:     alexandre.torgue@...com, peppe.cavallaro@...com,
        mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        joabreu@...opsys.com
Subject: Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on
 gmac4

From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Date: Tue,  5 Feb 2019 14:15:20 +0200

> The current driver only enables Pdelay_Req and Pdelay_Resp when
> HWTSTAMP_FILTER_PTP_V2_EVENT, HWTSTAMP_FILTER_PTP_V1_L4_EVENT or
> HWTSTAMP_FILTER_PTP_V2_L4_EVENT is requested. This results in ptp sync on
> slave mode to report 'received SYNC without timestamp' when using ptp4l.
> 
> Although the hardware can support Sync, Pdelay_Req and Pdelay_resp by
> setting bit14 annd bits 17/16 to 01 this leaves Delay_Req timestamps out.
> 
> Fix this by enabling all event and general messages timestamps.
> This includes SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req,
> Pdelay_Resp and Pdelay_Resp_Follow_Up messages.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

Applied to net-next, thanks.