netdev - Re: [PATCH]: net: hso: do not call unregister if not registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1549413511445.2427@ece.ufl.edu>
Date:   Wed, 6 Feb 2019 00:38:31 +0000
From:   "Yavuz, Tuba" <tuba@....ufl.edu>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH]: net: hso: do not call unregister if not registered

This is surprising as I got total: 0 errors, 0 warnings, 0 checks, 10 lines checked.

Anyhow, I'll submit as suggested.

Best,


Tuba Yavuz, Ph.D.
Assistant Professor
Electrical and Computer Engineering Department
University of Florida
Gainesville, FL 32611
Webpage: http://www.tuba.ece.ufl.edu/
Email: tuba@....ufl.edu
Phone: (352) 846 0202

________________________________________
From: David Miller <davem@...emloft.net>
Sent: Tuesday, February 5, 2019 7:36 PM
To: Yavuz, Tuba
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH]: net: hso: do not call unregister if not registered

From: "Yavuz, Tuba" <tuba@....ufl.edu>
Date: Tue, 5 Feb 2019 23:01:25 +0000

>
>
> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
>
> Signed-off-by: Tuba Yavuz <tuba@....ufl.edu>
> ---
>
> --- linux-stable/drivers/net/usb/hso.c.orig     2019-01-27 14:45:58.232683119 -0500
> +++ linux-stable/drivers/net/usb/hso.c  2019-02-05 17:54:17.056496019 -0500
> @@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h
>
>         remove_net_device(hso_net->parent);
>
> -       if (hso_net->net)
> +       if (hso_net->net &&
> +           hso_net->net->reg_state == NETREG_REGISTERED
> +          )

This is not formatted correctly, the final closing ')' should end the
previous line, like this:

       if (hso_net->net &&
           hso_net->net->reg_state == NETREG_REGISTERED)