netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Fix counting of ATU violations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 05 Feb 2019 16:38:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix counting of ATU violations

From: Andrew Lunn <andrew@...n.ch>
Date: Wed,  6 Feb 2019 00:02:58 +0100

> The ATU port vector contains a bit per port of the switch. The code
> wrongly used it as a port number, and incremented a port counter. This
> resulted in the wrong interfaces counter being incremented, and
> potentially going off the end of the array of ports.
> 
> Fix this by using the source port ID for the violation, which really
> is a port number.
> 
> Reported-by: Chris Healy <Chris.Healy@....aero>
> Tested-by: Chris Healy <Chris.Healy@....aero>
> Fixes: 65f60e4582bd ("net: dsa: mv88e6xxx: Keep ATU/VTU violation statistics")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied and queued up for -stable, thanks Andrew.