netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Fix counting of ATU violations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190206132833.GF9278@t480s.localdomain>
Date:   Wed, 6 Feb 2019 13:28:33 -0500
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix counting of ATU violations

Hi Andrew,

On Wed,  6 Feb 2019 00:02:58 +0100, Andrew Lunn <andrew@...n.ch> wrote:
> The ATU port vector contains a bit per port of the switch. The code
> wrongly used it as a port number, and incremented a port counter. This
> resulted in the wrong interfaces counter being incremented, and
> potentially going off the end of the array of ports.
> 
> Fix this by using the source port ID for the violation, which really
> is a port number.
> 
> Reported-by: Chris Healy <Chris.Healy@....aero>
> Tested-by: Chris Healy <Chris.Healy@....aero>
> Fixes: 65f60e4582bd ("net: dsa: mv88e6xxx: Keep ATU/VTU violation statistics")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Hey I guess you forgot to Cc me on this one. FWIW:

Reviewed-by: Vivien Didelot <vivien.didelot@...il.com>