netdev - Re: [PATCH net-next] ipvlan: decouple l3s mode dependencies from other modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7d5665a-9e53-7a75-e07f-ed44a03747de@iogearbox.net>
Date:   Fri, 8 Feb 2019 14:39:59 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Florian Westphal <fw@...len.de>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Mahesh Bandewar <maheshb@...gle.com>,
        Martynas Pumputis <m@...bda.lt>
Subject: Re: [PATCH net-next] ipvlan: decouple l3s mode dependencies from
 other modes

On 02/08/2019 02:29 PM, Florian Westphal wrote:
> Daniel Borkmann <daniel@...earbox.net> wrote:
>> Right now ipvlan has a hard dependency on CONFIG_NETFILTER and
>> otherwise it cannot be built. However, the only ipvlan operation
>> mode that actually depends on netfilter is l3s, everything else
>> is independent of it. Break this hard dependency such that users
>> are able to use ipvlan l3 mode on systems where netfilter is not
>> compiled in.
>>
>> Therefore, this adds a hidden CONFIG_IPVLAN_L3S bool which is
>> defaulting to y when CONFIG_NETFILTER is set in order to retain
>> existing behavior for l3s. All l3s related code is refactored
>> into ipvlan_l3s.c that is compiled in when enabled.
> 
> IIRC L3S is only meaningful with netfilter anyway, so this
> looks like a good thing to do.

Yep, agree, it doesn't work without it since inside ipvlan's nfhook
there is the final switch to the target ipvlan slave device. :)

> Acked-by: Florian Westphal <fw@...len.de>

Thanks!