lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Feb 2019 08:56:10 -0500 From: Willem de Bruijn <willemdebruijn.kernel@...il.com> To: Michal Kubecek <mkubecek@...e.cz> Cc: Network Development <netdev@...r.kernel.org>, "Nunley, Nicholas D" <nicholas.d.nunley@...el.com>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "linville@...driver.com" <linville@...driver.com>, "nhorman@...hat.com" <nhorman@...hat.com>, "sassmann@...hat.com" <sassmann@...hat.com> Subject: Re: [PATCH v2 3/6] ethtool: introduce new ioctl for per-queue settings On Fri, Feb 8, 2019 at 2:04 AM Michal Kubecek <mkubecek@...e.cz> wrote: > > On Thu, Feb 07, 2019 at 11:37:19PM +0000, Nunley, Nicholas D wrote: > > From: Michal Kubecek [mailto:mkubecek@...e.cz] > > > On Tue, Feb 05, 2019 at 04:01:03PM -0800, Jeff Kirsher wrote: > > > > Introduce a new ioctl for setting per-queue parameters. > > > > Users can apply commands to specific queues by setting SUB_COMMAND > > > and > > > > queue_mask with the following ethtool command: > > > > > > > > ethtool --set-perqueue-command DEVNAME [queue_mask %x] > > > SUB_COMMAND > > > > > > The "set" part is IMHO a bit confusing in combination with "show" type > > > subcommands. > > > > I'm not a fan of the "set" either. This patch set had already gone > > through some review before it was passed on to me, and the command > > naming wasn't a previous point of contention and I didn't want to > > disturb the parts that weren't "broken", but since you've brought it > > up I agree that this may not be the best name. I think > > "--perqueue-command" is more appropriate. Does this seem reasonable to > > you? > > That sounds good, I would say either that or "--per-queue". +1 --per-queue is short and easy to remember. And perhaps reserve short-hand '-Q'? I expect this to become a popular option. Especially if perhaps eventually it can dump per queue stats (-S).
Powered by blists - more mailing lists