lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 09 Feb 2019 09:33:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Add support for asking the PHY its
 abilities

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 9 Feb 2019 15:24:47 +0100

> From: Andrew Lunn <andrew@...n.ch>
> Add support for runtime determination of what the PHY supports, by
> adding a new function to the phy driver. The get_features call should
> set the phydev->supported member with the features the PHY supports.
> It is only called if phydrv->features is NULL.
> 
> This requires minor changes to pause. The PHY driver should not set
> pause abilities, except for when it has odd cause capabilities, e.g.
> pause cannot be disabled. With this change, phydev->supported already
> contains the drivers abilities, including pause. So rather than
> considering phydrv->features, look at the phydev->supported, and
> enable pause if neither of the pause bits are already set.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> [hkallweit1@...il.com: fixed small checkpatch complaint in one comment]
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.

Powered by blists - more mailing lists