netdev - Re: [PATCH net] af_key: unconditionally clone on broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190211.124554.1686370406673029680.davem@davemloft.net>
Date:   Mon, 11 Feb 2019 12:45:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     stranche@...eaurora.org
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org,
        steffen.klassert@...unet.com
Subject: Re: [PATCH net] af_key: unconditionally clone on broadcast

From: Sean Tranchetti <stranche@...eaurora.org>
Date: Thu,  7 Feb 2019 13:33:21 -0700

> Attempting to avoid cloning the skb when broadcasting by inflating
> the refcount with sock_hold/sock_put while under RCU lock is dangerous
> and violates RCU principles. It leads to subtle race conditions when
> attempting to free the SKB, as we may reference sockets that have
> already been freed by the stack.
 ...
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Sean Tranchetti <stranche@...eaurora.org>
> ---
> Realized I never actually sent this patch out after testing the changes
> Eric recommended. Whoops. Better late then never, I suppose...

Steffen, I assume you will review and pick this up.

Thanks.