netdev - Re: [PATCH net] af_key: unconditionally clone on broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190212121620.GU3087@gauss3.secunet.de>
Date:   Tue, 12 Feb 2019 13:16:21 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     David Miller <davem@...emloft.net>
CC:     <stranche@...eaurora.org>, <eric.dumazet@...il.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net] af_key: unconditionally clone on broadcast

On Mon, Feb 11, 2019 at 12:45:54PM -0800, David Miller wrote:
> From: Sean Tranchetti <stranche@...eaurora.org>
> Date: Thu,  7 Feb 2019 13:33:21 -0700
> 
> > Attempting to avoid cloning the skb when broadcasting by inflating
> > the refcount with sock_hold/sock_put while under RCU lock is dangerous
> > and violates RCU principles. It leads to subtle race conditions when
> > attempting to free the SKB, as we may reference sockets that have
> > already been freed by the stack.
>  ...
> > Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> > Signed-off-by: Sean Tranchetti <stranche@...eaurora.org>
> > ---
> > Realized I never actually sent this patch out after testing the changes
> > Eric recommended. Whoops. Better late then never, I suppose...
> 
> Steffen, I assume you will review and pick this up.

I was not on Cc and overlooked it at the list.
Thanks for the pointer!

Now applied to the ipsec tree, thanks Sean!