netdev - Re: [PATCH net] net/x25: do not hold the cpu too long in x25_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190211.132042.529132709200315406.davem@davemloft.net>
Date:   Mon, 11 Feb 2019 13:20:42 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, andrew.hendry@...il.com,
        linux-x25@...r.kernel.org
Subject: Re: [PATCH net] net/x25: do not hold the cpu too long in
 x25_new_lci()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri,  8 Feb 2019 12:41:05 -0800

> Due to quadratic behavior of x25_new_lci(), syzbot was able
> to trigger an rcu stall.
> 
> Fix this by not blocking BH for the whole duration of
> the function, and inserting a reschedule point when possible.
> 
> If we care enough, using a bitmap could get rid of the quadratic
> behavior.
> 
> syzbot report :
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied, thanks.