netdev - Re: [PATCH bpf-next 3/3] selftests: bpf: centre kernel bpf objects under new subdir "kern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190211040613.kc4zp7nedue6jt4k@ast-mbp>
Date:   Sun, 10 Feb 2019 20:06:15 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jiong Wang <jiong.wang@...ronome.com>
Cc:     daniel@...earbox.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next 3/3] selftests: bpf: centre kernel bpf objects
 under new subdir "kern_progs"

On Fri, Feb 08, 2019 at 05:41:21PM +0000, Jiong Wang wrote:
> At the moment, all kernel bpf objects are listed under BPF_OBJ_FILES.
> Listing them manually sometimes causing patch conflict when people are
> adding new testcases simultaneously.
> 
> It is better to centre all the related source files under a subdir
> "kern_progs", then auto-generate the object file list.
> 
> Suggested-by: Alexei Starovoitov <ast@...nel.org>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Signed-off-by: Jiong Wang <jiong.wang@...ronome.com>
> ---
>  tools/testing/selftests/bpf/Makefile               | 26 +++++-----------------
>  .../selftests/bpf/{ => kern_progs}/bpf_flow.c      |  0
>  .../selftests/bpf/{ => kern_progs}/connect4_prog.c |  0
>  .../selftests/bpf/{ => kern_progs}/connect6_prog.c |  0
>  .../selftests/bpf/{ => kern_progs}/dev_cgroup.c    |  0

Thanks a lot for the patch.
A tiny bit of bikeshedding...
'kern_progs' feels a bit too long and awkward to type.
May be just 'progs' ?