lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190211040844.cwghalpoqwidjyo4@ast-mbp> Date: Sun, 10 Feb 2019 20:08:45 -0800 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Magnus Karlsson <magnus.karlsson@...el.com> Cc: bjorn.topel@...el.com, ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org Subject: Re: [PATCH bpf] xsk: add missing smp_rmb() in xsk_mmap On Fri, Feb 08, 2019 at 02:13:50PM +0100, Magnus Karlsson wrote: > All the setup code in AF_XDP is protected by a mutex with the > exception of the mmap code that cannot use it. To make sure that a > process banging on the mmap call at the same time as another process > is setting up the socket, smp_wmb() calls were added in the umem > registration code and the queue creation code, so that the published > structures that xsk_mmap needs would be consistent. However, the > corresponding smp_rmb() calls were not added to the xsk_mmap > code. This patch adds these calls. > > Fixes: 37b076933a8e3 ("xsk: add missing write- and data-dependency barrier") > Fixes: c0c77d8fb787c ("xsk: add user memory registration support sockopt") > Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com> Applied, Thanks
Powered by blists - more mailing lists