lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <40215a8b-3b64-cf6c-c6cd-7d8d5dd971d3@embeddedor.com> Date: Mon, 11 Feb 2019 19:47:28 -0600 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Pablo Neira Ayuso <pablo@...filter.org>, Simon Horman <horms@...ge.net.au> Cc: Wensong Zhang <wensong@...ux-vs.org>, Julian Anastasov <ja@....bg>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Florian Westphal <fw@...len.de>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] ipvs: Use struct_size() helper On 2/11/19 5:40 PM, Pablo Neira Ayuso wrote: > On Fri, Feb 08, 2019 at 10:56:48AM +0100, Simon Horman wrote: >> On Thu, Feb 07, 2019 at 06:44:56PM -0600, Gustavo A. R. Silva wrote: >>> One of the more common cases of allocation size calculations is finding >>> the size of a structure that has a zero-sized array at the end, along >>> with memory for some number of elements for that array. For example: >>> >>> struct foo { >>> int stuff; >>> struct boo entry[]; >>> }; >>> >>> size = sizeof(struct foo) + count * sizeof(struct boo); >>> instance = alloc(size, GFP_KERNEL) >>> >>> Instead of leaving these open-coded and prone to type mistakes, we can >>> now use the new struct_size() helper: >>> >>> size = struct_size(instance, entry, count); >>> >>> This code was detected with the help of Coccinelle. >>> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> >> >> Acked-by: Simon Horman <horms+renesas@...ge.net.au> >> >> Pablo, could you consider applying this? > > Applied, thanks! > Thank you both, Simon and Pablo. -- Gustavo
Powered by blists - more mailing lists