[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190211.183624.1085166229826606719.davem@davemloft.net>
Date: Mon, 11 Feb 2019 18:36:24 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: hoang.h.le@...tech.com.au
Cc: tipc-discussion@...ts.sourceforge.net, jon.maloy@...csson.com,
maloy@...jonn.com, ying.xue@...driver.com, netdev@...r.kernel.org
Subject: Re: [net] tipc: fix skb may be leaky in tipc_link_input
From: Hoang Le <hoang.h.le@...tech.com.au>
Date: Mon, 11 Feb 2019 09:18:28 +0700
> When we free skb at tipc_data_input, we return a 'false' boolean.
> Then, skb passed to subcalling tipc_link_input in tipc_link_rcv,
>
> <snip>
> 1303 int tipc_link_rcv:
> ...
> 1354 if (!tipc_data_input(l, skb, l->inputq))
> 1355 rc |= tipc_link_input(l, skb, l->inputq);
> </snip>
>
> Fix it by simple changing to a 'true' boolean when skb is being free-ed.
> Then, tipc_link_rcv will bypassed to subcalling tipc_link_input as above
> condition.
>
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Acked-by: Jon Maloy <maloy@...jonn.com>
> Signed-off-by: Hoang Le <hoang.h.le@...tech.com.au>
Applied, thanks.
Powered by blists - more mailing lists