netdev - Re: [PATCH] rpc: properly check debugfs dentry before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 20:52:53 +0000
From:   "Schumaker, Anna" <Anna.Schumaker@...app.com>
To:     "bfields@...ldses.org" <bfields@...ldses.org>,
        "trond.myklebust@...merspace.com" <trond.myklebust@...merspace.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jlayton@...nel.org" <jlayton@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "dhowells@...hat.com" <dhowells@...hat.com>
Subject: Re: [PATCH] rpc: properly check debugfs dentry before using it

On Tue, 2019-02-12 at 19:27 +0100, Greg Kroah-Hartman wrote:
> debugfs can now report an error code if something went wrong instead of
> just NULL.  So if the return value is to be used as a "real" dentry, it
> needs to be checked if it is an error before dereferencing it.
> 
> This is now happening because of ff9fb72bc077 ("debugfs: return error
> values, not NULL"), but why debugfs files are not being created properly
> is an older issue, probably one that has always been there and should
> probably be looked at...
> 
> Cc: "J. Bruce Fields" <bfields@...ldses.org>
> Cc: Jeff Layton <jlayton@...nel.org>
> Cc: Trond Myklebust <trond.myklebust@...merspace.com>
> Cc: Anna Schumaker <anna.schumaker@...app.com>
> Cc: linux-nfs@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Reported-by: David Howells <dhowells@...hat.com>
> Tested-by: David Howells <dhowells@...hat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  net/sunrpc/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I can take this through my tree if people don't object, or it can go
> through the NFS tree.  It does need to get merged before 5.0-final
> though.

I'm planning another bugfixes pull for 5.0, so I can take this patch and send it
with the others this week.

Thanks!
Anna

> 
> I also have a "larger" debugfs cleanup patch for this file, but that's
> not really 5.0-final material and I will send it out later.
> 
> thanks,
> 
> greg k-h
> 
> diff --git a/net/sunrpc/debugfs.c b/net/sunrpc/debugfs.c
> index 45a033329cd4..19bb356230ed 100644
> --- a/net/sunrpc/debugfs.c
> +++ b/net/sunrpc/debugfs.c
> @@ -146,7 +146,7 @@ rpc_clnt_debugfs_register(struct rpc_clnt *clnt)
>         rcu_read_lock();
>         xprt = rcu_dereference(clnt->cl_xprt);
>         /* no "debugfs" dentry? Don't bother with the symlink. */
> -       if (!xprt->debugfs) {
> +       if (IS_ERR_OR_NULL(xprt->debugfs)) {
>                 rcu_read_unlock();
>                 return;
>         }