netdev - Re: [PATCH] rpc: properly check debugfs dentry before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190213072433.GA10225@kroah.com>
Date:   Wed, 13 Feb 2019 08:24:33 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     "Schumaker, Anna" <Anna.Schumaker@...app.com>
Cc:     "bfields@...ldses.org" <bfields@...ldses.org>,
        "trond.myklebust@...merspace.com" <trond.myklebust@...merspace.com>,
        "jlayton@...nel.org" <jlayton@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "dhowells@...hat.com" <dhowells@...hat.com>
Subject: Re: [PATCH] rpc: properly check debugfs dentry before using it

On Tue, Feb 12, 2019 at 08:52:53PM +0000, Schumaker, Anna wrote:
> On Tue, 2019-02-12 at 19:27 +0100, Greg Kroah-Hartman wrote:
> > debugfs can now report an error code if something went wrong instead of
> > just NULL.  So if the return value is to be used as a "real" dentry, it
> > needs to be checked if it is an error before dereferencing it.
> > 
> > This is now happening because of ff9fb72bc077 ("debugfs: return error
> > values, not NULL"), but why debugfs files are not being created properly
> > is an older issue, probably one that has always been there and should
> > probably be looked at...
> > 
> > Cc: "J. Bruce Fields" <bfields@...ldses.org>
> > Cc: Jeff Layton <jlayton@...nel.org>
> > Cc: Trond Myklebust <trond.myklebust@...merspace.com>
> > Cc: Anna Schumaker <anna.schumaker@...app.com>
> > Cc: linux-nfs@...r.kernel.org
> > Cc: netdev@...r.kernel.org
> > Reported-by: David Howells <dhowells@...hat.com>
> > Tested-by: David Howells <dhowells@...hat.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > ---
> >  net/sunrpc/debugfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > I can take this through my tree if people don't object, or it can go
> > through the NFS tree.  It does need to get merged before 5.0-final
> > though.
> 
> I'm planning another bugfixes pull for 5.0, so I can take this patch and send it
> with the others this week.

Wonderful, thanks for doing this, and sorry for the regression.

greg k-h