netdev - Re: [RFC 17/19] RDMA/irdma: Add ABI definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 16:05:08 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Shiraz Saleem <shiraz.saleem@...el.com>
Cc:     dledford@...hat.com, davem@...emloft.net,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        mustafa.ismail@...el.com, jeffrey.t.kirsher@...el.com
Subject: Re: [RFC 17/19] RDMA/irdma: Add ABI definitions

On Tue, Feb 12, 2019 at 03:44:00PM -0600, Shiraz Saleem wrote:

> +struct irdma_create_cq_req {
> +	__aligned_u64 user_cq_buf;
> +	__aligned_u64 user_shadow_area;
> +};

This is the right way to use u64 in uapi headers

> +
> +struct irdma_create_qp_req {
> +	__u64 user_wqe_bufs;
> +	__u64 user_compl_ctx;
> +};

and this is wrong.. See my prior email.

Jason