netdev - Re: [PATCH net] net: dsa: bcm_sf2: potential array overflow in bcm_sf2_sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190213081313.GB26654@t480s.localdomain>
Date:   Wed, 13 Feb 2019 08:13:13 -0500
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: bcm_sf2: potential array overflow in
 bcm_sf2_sw_suspend()

On Wed, 13 Feb 2019 11:23:04 +0300, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> The value of ->num_ports comes from bcm_sf2_sw_probe() and it is less
> than or equal to DSA_MAX_PORTS.  The ds->ports[] array is used inside
> the dsa_is_user_port() and dsa_is_cpu_port() functions.  The ds->ports[]
> array is allocated in dsa_switch_alloc() and it has ds->num_ports
> elements so this leads to a static checker warning about a potential out
> of bounds read.
> 
> Fixes: 8cfa94984c9c ("net: dsa: bcm_sf2: add suspend/resume callbacks")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Vivien Didelot <vivien.didelot@...il.com>