netdev - Re: [PATCH 1/3 net-next] lib: objagg: Fix an error code in objagg_hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190213131542.GB2186@nanopsycho>
Date:   Wed, 13 Feb 2019 14:15:42 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        Ido Schimmel <idosch@...lanox.com>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/3 net-next] lib: objagg: Fix an error code in
 objagg_hints_get()

Wed, Feb 13, 2019 at 09:56:50AM CET, dan.carpenter@...cle.com wrote:
>We need to set the error code on this path otherwise we return
>ERR_PTR(0) which would result in a NULL dereference in the caller.
>
>Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation")
>Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

I have the same patch in my queue.

Acked-by: Jiri Pirko <jiri@...lanox.com>