netdev - Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Feb 2019 08:38:28 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vkoul@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, niklas.cassel@...aro.org, andrew@...n.ch,
        f.fainelli@...il.com, nsekhar@...com, peter.ujfalusi@...com,
        marc.w.gonzalez@...e.fr
Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode

From: Vinod Koul <vkoul@...nel.org>
Date: Tue, 12 Feb 2019 19:49:22 +0530

> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 8ff12938ab47..7b54b54e3316 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
>  	return phy_write(phydev, AT803X_DEBUG_DATA, val);
>  }
>  
> +static inline int at803x_enable_rx_delay(struct phy_device *phydev)
> +{
> +	return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0,
> +				     AT803X_DEBUG_RX_CLK_DLY_EN);
> +}
> +
> +static inline int at803x_enable_tx_delay(struct phy_device *phydev)
> +{
> +	return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0,
> +				     AT803X_DEBUG_TX_CLK_DLY_EN);
> +}
> +

Please do not use the inline directive in foo.c files, let the compiler
decide.

Thank you.