lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190214.084343.1138362153341500718.davem@davemloft.net> Date: Thu, 14 Feb 2019 08:43:43 -0800 (PST) From: David Miller <davem@...emloft.net> To: s-nazarov@...dex.ru Cc: netdev@...r.kernel.org, linux-security-module@...r.kernel.org, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, paul@...l-moore.com Subject: Re: [PATCH] NETWORKING: avoid use IPCB in cipso_v4_error From: Nazarov Sergey <s-nazarov@...dex.ru> Date: Tue, 12 Feb 2019 18:10:03 +0300 > Since cipso_v4_error might be called from different network stack layers, we can't safely use icmp_send there. > icmp_send copies IP options with ip_option_echo, which uses IPCB to take access to IP header compiled data. > But after commit 971f10ec ("tcp: better TCP_SKB_CB layout to reduce cache line misses"), IPCB can't be used > above IP layer. > This patch fixes the problem by creating in cipso_v4_error a local copy of compiled IP options and using it with > introduced __icmp_send function. This looks some overloaded, but in quite rare error conditions only. > > The original discussion is here: > https://lore.kernel.org/linux-security-module/16659801547571984@sas1-890ba5c2334a.qloud-c.yandex.net/ > > Signed-off-by: Sergey Nazarov <s-nazarov@...dex.ru> This problem is not unique to Cipso, net/atm/clip.c's error handler has the same exact issue. I didn't scan more of the tree, there are probably a couple more locations as well.
Powered by blists - more mailing lists