netdev - Re: [PATCH net-next] net: sched: flower: only return error from hw offload if skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190213.210704.1651652558023166187.davem@davemloft.net>
Date:   Wed, 13 Feb 2019 21:07:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, pablo@...filter.org
Subject: Re: [PATCH net-next] net: sched: flower: only return error from hw
 offload if skip_sw

From: Vlad Buslov <vladbu@...lanox.com>
Date: Tue, 12 Feb 2019 23:39:06 +0200

> Recently introduced tc_setup_flow_action() can fail when parsing tcf_exts
> on some unsupported action commands. However, this should not affect the
> case when user did not explicitly request hw offload by setting skip_sw
> flag. Modify tc_setup_flow_action() callers to only propagate the error if
> skip_sw flag is set for filter that is being offloaded, and set extack
> error message in that case.
> 
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
> Fixes: 3a7b68617de7 ("cls_api: add translator to flow_action representation")

Applied, thanks Vlad.