lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190213.210836.1913705958843558074.davem@davemloft.net> Date: Wed, 13 Feb 2019 21:08:36 -0800 (PST) From: David Miller <davem@...emloft.net> To: john.hurley@...ronome.com Cc: jiri@...lanox.com, netdev@...r.kernel.org, pablo@...filter.org, oss-drivers@...ronome.com Subject: Re: [PATCH net-next 1/1] flow_offload: fix block stats From: John Hurley <john.hurley@...ronome.com> Date: Wed, 13 Feb 2019 00:23:52 +0000 > With the introduction of flow_stats_update(), drivers now update the stats > fields of the passed tc_cls_flower_offload struct, rather than call > tcf_exts_stats_update() directly to update the stats of offloaded TC > flower rules. However, if multiple qdiscs are registered to a TC shared > block and a flower rule is applied, then, when getting stats for the rule, > multiple callbacks may be made. > > Take this into consideration by modifying flow_stats_update to gather the > stats from all callbacks. Currently, the values in tc_cls_flower_offload > only account for the last stats callback in the list. > > Fixes: 3b1903ef97c0 ("flow_offload: add statistics retrieval infrastructure and use it") > Signed-off-by: John Hurley <john.hurley@...ronome.com> > Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com> Applied, thanks.
Powered by blists - more mailing lists