lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190215133459.GH5699@lunn.ch> Date: Fri, 15 Feb 2019 14:34:59 +0100 From: Andrew Lunn <andrew@...n.ch> To: Claudiu Manoil <claudiu.manoil@....com> Cc: Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>, "David S . Miller" <davem@...emloft.net>, alexandru.marginean@....com, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO support On Fri, Feb 15, 2019 at 12:10:14PM +0200, Claudiu Manoil wrote: > Each ENETC PF has its own MDIO interface, the corresponding > MDIO registers are mapped in the ENETC's Port register block. > The current patch adds a driver for these PF level MDIO buses, > so that each PF can manage directly its own external link. > > Signed-off-by: Alex Marginean <alexandru.marginean@....com> > Signed-off-by: Claudiu Manoil <claudiu.manoil@....com> > --- > v2 - used readx_poll_timeout() > - added mdio node child to the port node Hi Claudiu Please document this in the device tree binding. > + /* return all Fs if nothing was there */ > + if (enetc_rd_reg(®s->mdio_cfg) & MDIO_CFG_RD_ER) { > + dev_err(&bus->dev, > + "Error while reading PHY%d reg at %d.%hhu\n", > + phy_id, dev_addr, regnum); > + return 0xffff; I'm not sure you want a dev_err() here. The device tree binding allows you to have a phy node without a reg value. When that happens, the core code will scan all 32 addresses to find the PHY. This is going to spam the log. dev_dbg() might be better. Andrew
Powered by blists - more mailing lists