netdev - Re: [PATCH bpf-next v2] bpf: make LWTUNNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bbc8f63-3033-44ba-5b8e-ae597677bbe6@infradead.org>
Date:   Fri, 15 Feb 2019 14:55:58 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Peter Oskolkov <posk@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Cc:     Peter Oskolkov <posk@...k.io>
Subject: Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET

On 2/15/19 9:51 AM, Peter Oskolkov wrote:
> Lightweight tunnels are L3 constructs that are used with IP/IP6.
> 
> For example, lwtunnel_xmit is called from ip_output.c and
> ip6_output.c only.
> 
> Make the dependency explicit at least for LWT-BPF, as now they
> call into IP routing.
> 
> V2: added "Reported-by" below.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>

Yes, that works.  Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> ---
>  net/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/Kconfig b/net/Kconfig
> index 5cb9de1aaf88..62da6148e9f8 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -403,7 +403,7 @@ config LWTUNNEL
>  
>  config LWTUNNEL_BPF
>  	bool "Execute BPF program as route nexthop action"
> -	depends on LWTUNNEL
> +	depends on LWTUNNEL && INET
>  	default y if LWTUNNEL=y
>  	---help---
>  	  Allows to run BPF programs as a nexthop action following a route
> 


-- 
~Randy