netdev - Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9eea4d0-88d4-e903-8a9f-7f1b8b276c21@ti.com>
Date:   Mon, 18 Feb 2019 18:22:31 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Tony Lindgren <tony@...mide.com>
CC:     <bcousson@...libre.com>, <linux-omap@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <nsekhar@...com>,
        <grygorii.strashko@...com>, <vkoul@...nel.org>,
        <netdev@...r.kernel.org>, <f.fainelli@...il.com>,
        <marc.w.gonzalez@...e.fr>, <niklas.cassel@...aro.org>
Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet



On 18/02/2019 16.44, Tony Lindgren wrote:
> * Peter Ujfalusi <peter.ujfalusi@...com> [190218 14:36]:
>> Hi,
>>
>> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the
>> ethernet networking on evmsk (and most likely on the evm as well):
>> https://patchwork.ozlabs.org/patch/1028527/
>>
>> v1 patch to fix the situation:
>> https://patchwork.ozlabs.org/patch/1040617/
>>
>> It turned out that the at803x driver is actually broken and need to be fixed
>> along with the DT data.
>>
>> The following series is proposed to fix the driver:
>> https://patchwork.ozlabs.org/project/netdev/list/?series=92611
>>
>> but the PHT mode needs to be switched to rgmii-id from rgmii-txid:
>> The rx delay is enabled by default and the driver never disabled it so when
>> asking rgmii-txid it actually got rgmii-id.
>>
>> The patch can be backported to stable, I have tested that it is not causing
>> regression with the old, broken driver.
> 
> Can the dts changes be merged before the driver changes or
> does it cause the phy to stop working?

The phy is not working atm, but this change will not cause regression
even if it is merged first.

> 
> Regards,
> 
> Tony
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki