netdev - Re: [net PATCH] net: vrf: remove MTU limits for vrf device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c3ed35a-9690-e4e2-7682-8b517d0f1921@cumulusnetworks.com>
Date:   Mon, 18 Feb 2019 09:25:37 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     "David S . Miller" <davem@...emloft.net>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [net PATCH] net: vrf: remove MTU limits for vrf device

On 2/18/19 2:14 AM, Hangbin Liu wrote:
> Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and
> ifb device"), MTU is irrelevant for VRF device. We init it as 64K while
> limit it to [68, 1500] may make users feel confused.
> 
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  drivers/net/vrf.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index 95909e262ba4..7c1430ed0244 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -1273,6 +1273,9 @@ static void vrf_setup(struct net_device *dev)
>  
>  	/* default to no qdisc; user can add if desired */
>  	dev->priv_flags |= IFF_NO_QUEUE;
> +
> +	dev->min_mtu = 0;
> +	dev->max_mtu = 0;
>  }
>  
>  static int vrf_validate(struct nlattr *tb[], struct nlattr *data[],
> 

Reviewed-by: David Ahern <dsahern@...il.com>