netdev - Re: Possible bug into DSA2 code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190219000340.GJ14879@lunn.ch>
Date:   Tue, 19 Feb 2019 01:03:40 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Rodolfo Giometti <giometti@...eenne.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: Possible bug into DSA2 code.

> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 54a5b660640a..bb46ebbb2bb8 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
>         int i;
> 
>         chip->ds = ds;
> -       ds->slave_mii_bus = mv88e6xxx_default_mdio_bus(chip);
> +       ds->slave_mii_bus = NULL;
> 
>         mutex_lock(&chip->reg_lock);
> 
> Is that right?

Hi Rodolfo

Humm, that needs testing. There are two used combinations you need to
test:

No MDIO node in device tree, e.g.
arch/arm/boot/dts/kirkwood-dir665.dts

MDIO node in device tree, e.g:
arch/arm/boot/dts/vf610-zii-dev-rev-b.dts

There is a third combination which will appear soon. There is only the
external mdio bus in device tree:

                                port@9 {
                                        reg = <9>;
                                        label = "eth_cu_1000_2";
                                        phy-handle = <&phy9>;
                                        phy-mode = "sgmii";
                                        managed = "in-band-status";
                                };
                        };

                        mdio1 {
                                compatible = "marvell,mv88e6xxx-mdio-external";
                                #address-cells = <1>;
                                #size-cells = <0>;

                                phy9: phy9@0 {
                                        compatible = "ethernet-phy-ieee802.3-c45";
                                        pinctrl-0 = <&pinctrl_gpio_phy9>;
                                        pinctrl-names = "default";
                                        interrupt-parent = <&gpio2>;
                                        interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
                                        reg = <0>;
                                };
                        };

Here port 9 uses the external MDIO bus and all the other ports
implicitly make use of the internal MDIO bus.

     Andrew