lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 19 Feb 2019 17:23:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Walter Harms <wharms@....de>
Cc:     Mao Wenan <maowenan@...wei.com>, kernel-janitors@...r.kernel.org,
        netdev@...r.kernel.org, john.fastabend@...il.com, hawk@...nel.org,
        jakub.kicinski@...ronome.com, daniel@...earbox.net, ast@...nel.org,
        julia.lawall@...6.fr
Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy()

On Tue, Feb 19, 2019 at 01:42:03PM +0100, Walter Harms wrote:
> 
> Am 19.02.2019 10:06, schrieb Mao Wenan:
> > -
> >  	for (i=1; i<2; i++) {
> 
> 
> the loop here seems also pointless, so you can eliminate i.
> (or did i muss something ?)
> 

True.  But please do it in a separate patch.

regards,
dan carpenter


Powered by blists - more mailing lists