lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 19 Feb 2019 18:46:42 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Walter Harms <wharms@....de>
Cc:     Mao Wenan <maowenan@...wei.com>, kernel-janitors@...r.kernel.org,
        netdev@...r.kernel.org, john.fastabend@...il.com, hawk@...nel.org,
        jakub.kicinski@...ronome.com, daniel@...earbox.net, ast@...nel.org,
        julia.lawall@...6.fr
Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy()

> >  	for (i=1; i<2; i++) {
> 
> 
> the loop here seems also pointless, so you can eliminate i.
> (or did i muss something ?)

If you widen out your view a bit, you find all this code is inside a
#ifdef PHY_CODE_IS_FINISHED. I don't see anything which actually
defines that.

So a lot more code could probably be removed.

   Andrew

Powered by blists - more mailing lists