netdev - Re: [PATCH net v2] team: use operstate consistently for linkup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190220083638.GK3080@nanopsycho>
Date:   Wed, 20 Feb 2019 09:36:38 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     George Wilkie <gwilkie@...tta.att-mail.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] team: use operstate consistently for linkup

Wed, Feb 20, 2019 at 09:19:11AM CET, gwilkie@...tta.att-mail.com wrote:
>When a port is added to a team, its initial state is derived
>from netif_carrier_ok rather than netif_oper_up.
>If it is carrier up but operationally down at the time of being
>added, the port state.linkup will be set prematurely.
>port state.linkup should be set consistently using
>netif_oper_up rather than netif_carrier_ok.
>
>Fixes: f1d22a1e0595 ("team: account for oper state")
>Signed-off-by: George Wilkie <gwilkie@...tta.att-mail.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>