lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190220083749.GL3080@nanopsycho> Date: Wed, 20 Feb 2019 09:37:49 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, oss-drivers@...ronome.com, mkubecek@...e.cz, andrew@...n.ch Subject: Re: [PATCH net-next 3/3] nfp: devlink: allow flashing the device via devlink Wed, Feb 20, 2019 at 01:49:26AM CET, jakub.kicinski@...ronome.com wrote: >On Tue, 19 Feb 2019 10:19:42 +0100, Jiri Pirko wrote: >> Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicinski@...ronome.com wrote: >> >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote: >> >> > static const struct ethtool_ops nfp_net_ethtool_ops = { >> >> >> >> Why don't you use the compat fallback? I think you should. >> > >> >You and Michal both asked the same so let me answer the first to ask :) >> >- if devlink is built as a module the fallback is not reachable. >> >> So the fallback is not really good as you can't use it for real drivers >> anyway. Odd. Maybe we should compile devlink in without possibility to >> have it as module. > >Ack, I'll make devlink a bool. Thanks! > >I need a little extra time, I forgot that nfp's flower offload still >doesn't register all ports (using your port flavour infrastructure). Finally :)
Powered by blists - more mailing lists