netdev - Re: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221151753.GC5894@lunn.ch>
Date:   Thu, 21 Feb 2019 16:17:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Pankaj Bansal <pankaj.bansal@....com>
Cc:     Leo Li <leoyang.li@....com>, Peter Rosin <peda@...ntia.se>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux
 controls

> > >  config MDIO_BUS_MUX
> > >  	tristate
> > >  	depends on OF_MDIO
> > > +	select MULTIPLEXER
> > >  	help
> > >  	  This module provides a driver framework for MDIO bus
> > >  	  multiplexers which connect one of several child MDIO busses
> > 
> > Hi Pankaj
> > 
> > Please add a MDIO_BUS_MUX_MULTIPLEXER and put all the code into mdio-
> > mux-multiplexer.c
> 
> Isn't MUX short for MULTIPLEXER ? wouldn't this be more confusing ?

Look at the pattern:

config MDIO_BUS_MUX
config MDIO_BUS_MUX_BCM_IPROC
config MDIO_BUS_MUX_GPIO
config MDIO_BUS_MUX_MMIOREG

You are adding another sort of MUX, A Mux that uses a kernel
Multiplexer.  Hence the name should be MDIO_BUS_MUX_MULTIPLEXER.

You can try to avoid confusion by using good help text:

  	help This module provides a driver for MDIO bus multiplexer
	  that is controlled via the kernel multiplexer subsystem. The
	  bus multiplexer connects one of several child MDIO busses to
	  a parent bus.  Child bus selection is under the control of
	  the kernel multiplexer subsystem.

This test basically follows the other MDIO multiplexers.

     Andrew