netdev - RE: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Feb 2019 14:15:11 +0000
From:   Pankaj Bansal <pankaj.bansal@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Leo Li <leoyang.li@....com>, Peter Rosin <peda@...ntia.se>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux
 controls



> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@...n.ch]
> Sent: Thursday, 21 February, 2019 07:12 PM
> To: Pankaj Bansal <pankaj.bansal@....com>
> Cc: Leo Li <leoyang.li@....com>; Peter Rosin <peda@...ntia.se>; Florian
> Fainelli <f.fainelli@...il.com>; Heiner Kallweit <hkallweit1@...il.com>;
> netdev@...r.kernel.org
> Subject: Re: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux
> controls
> 
> On Thu, Feb 21, 2019 at 01:00:44PM +0000, Pankaj Bansal wrote:
> > Add support for Generic Mux controls, when Mdio mux node is a consumer
> > of mux produced by some other device.
> >
> > Signed-off-by: Pankaj Bansal <pankaj.bansal@....com>
> > ---
> >  drivers/net/phy/Kconfig    |  1 +
> >  drivers/net/phy/mdio-mux.c | 81 ++++++++++++++++++++++++++++++++++++
> >  2 files changed, 82 insertions(+)
> >
> > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index
> > 3d187cd50eb0..e0e6b2b33d6d 100644
> > --- a/drivers/net/phy/Kconfig
> > +++ b/drivers/net/phy/Kconfig
> > @@ -47,6 +47,7 @@ config MDIO_BITBANG
> >  config MDIO_BUS_MUX
> >  	tristate
> >  	depends on OF_MDIO
> > +	select MULTIPLEXER
> >  	help
> >  	  This module provides a driver framework for MDIO bus
> >  	  multiplexers which connect one of several child MDIO busses
> 
> Hi Pankaj
> 
> Please add a MDIO_BUS_MUX_MULTIPLEXER and put all the code into mdio-
> mux-multiplexer.c

Isn't MUX short for MULTIPLEXER ? wouldn't this be more confusing ?
I have kept the mux APIs code unchanged, so as to not disturb the existing drivers that use these APIs.

> 
> > +static const struct of_device_id mdio_mux_match[] = {
> > +	{ .compatible = "mdio-mux", },
> 
> mdio-mux-multiplexer

Again, isn't mux short for multiplexer? wouldn't this be more confusing ?

> 
> Thanks
> 	Andrew