netdev - Re: [PATCH] samples/bpf: Fix dummy program unloading for xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221224735.wf4364mmyajw7ly7@kafai-mbp.dhcp.thefacebook.com>
Date:   Thu, 21 Feb 2019 22:47:36 +0000
From:   Martin Lau <kafai@...com>
To:     Maciej Fijalkowski <maciejromanfijalkowski@...il.com>
CC:     Toke Høiland-Jørgensen <toke@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] samples/bpf: Fix dummy program unloading for xdp_redirect
 samples

On Thu, Feb 21, 2019 at 05:30:54PM +0100, Maciej Fijalkowski wrote:
> On Thu, 21 Feb 2019 17:05:39 +0100
> Toke Høiland-Jørgensen <toke@...hat.com> wrote:
> 
> > The xdp_redirect and xdp_redirect_map sample programs both load a dummy
> > program onto the egress interfaces. However, the unload code checks these
> > programs against the wrong fd number, and thus refuses to unload them. Fix
s/fd/id/

> > the comparison to avoid this.
The change LGTM.

Acked-by: Martin KaFai Lau <kafai@...com>