netdev - Re: [PATCH] samples/bpf: Fix dummy program unloading for xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61aa2e3c-a804-28a3-5d2f-fc9f3e178514@iogearbox.net>
Date:   Fri, 22 Feb 2019 16:23:38 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martin Lau <kafai@...com>,
        Maciej Fijalkowski <maciejromanfijalkowski@...il.com>
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] samples/bpf: Fix dummy program unloading for xdp_redirect
 samples

On 02/21/2019 11:47 PM, Martin Lau wrote:
> On Thu, Feb 21, 2019 at 05:30:54PM +0100, Maciej Fijalkowski wrote:
>> On Thu, 21 Feb 2019 17:05:39 +0100
>> Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>>
>>> The xdp_redirect and xdp_redirect_map sample programs both load a dummy
>>> program onto the egress interfaces. However, the unload code checks these
>>> programs against the wrong fd number, and thus refuses to unload them. Fix
> s/fd/id/

Applied and fixed above typo, thanks!

>>> the comparison to avoid this.
> The change LGTM.
> 
> Acked-by: Martin KaFai Lau <kafai@...com>
>