netdev - Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190223.132117.343025457687449183.davem@davemloft.net>
Date:   Sat, 23 Feb 2019 13:21:17 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     laoar.shao@...il.com
Cc:     daniel@...earbox.net, edumazet@...gle.com, joe@...ches.com,
        xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        shaoyafang@...iglobal.com
Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING

From: Yafang Shao <laoar.shao@...il.com>
Date: Sun, 17 Feb 2019 22:26:32 +0800

> SOCK_DEBUG() is a old facility for debugging.
> If the user want to use it for debugging, the user must modify the
> application first, that doesn't seem like a good way.
> Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind
> of debugging purpose.
> So we'd better disable it by default.
> The reason why I don't remove it comepletely is that someone may still
> would like to use it for debugging.
> 
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> Suggested-by: Joe Perches <joe@...ches.com>

Sorry, I'm not applying this.

You are forcing everyone who wants to use this to add a curstom local
source code change into their build.

I'm OK with patch #1, and Eric suggested it, so if you want to submit
that separately that's fine.